Skip to content

Fix chromedriver headless syntax for v120#12160

Closed
andreslucena wants to merge 6 commits intodevelopfrom
fix/chrome-headless-syntax-with-120
Closed

Fix chromedriver headless syntax for v120#12160
andreslucena wants to merge 6 commits intodevelopfrom
fix/chrome-headless-syntax-with-120

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

Related to the failing spec from #12159, in Selenium they mention that we should fix the syntax of the arguments.

(Same as in #12159, I'm labeling as a fix so we can backport this)

Testing

All the test suite should be green

♥️ Thank you!

@andreslucena andreslucena added the type: fix PRs that implement a fix for a bug label Dec 13, 2023
github-actions[bot]
github-actions bot previously approved these changes Dec 13, 2023
@andreslucena andreslucena marked this pull request as draft December 13, 2023 08:04
@andreslucena
Copy link
Copy Markdown
Member Author

I can't reproduce the failing specs locally as it seems that google-chrome v120 is just too bleeding edge and not even my operating system has a working version:

$ sudo apt upgrade
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Calculating upgrade... Done
The following packages were automatically installed and are no longer required:
  docker-scan-plugin gconf-service gconf-service-backend gconf2-common libgconf-2-4 libwmf0.2-7 linux-headers-6.2.6-76060206 linux-headers-6.4.6-76060406 linux-headers-6.4.6-76060406-generic linux-image-6.4.6-76060406-generic
  linux-modules-6.4.6-76060406-generic
Use 'sudo apt autoremove' to remove them.
The following packages have been kept back:
  lldb
The following packages will be upgraded:
  google-chrome-stable
1 upgraded, 0 newly installed, 0 to remove and 1 not upgraded.
Need to get 105 MB of archives.
After this operation, 4.292 kB of additional disk space will be used.
Do you want to continue? [Y/n] 
Get:1 http://apt.pop-os.org/proprietary jammy/main amd64 google-chrome-stable amd64 120.0.6099.109-1 [105 MB]
Err:1 http://apt.pop-os.org/proprietary jammy/main amd64 google-chrome-stable amd64 120.0.6099.109-1
  File has unexpected size (104920896 != 104995956). Mirror sync in progress? [IP: 13.224.115.4 80]
  Hashes of expected file:
   - SHA512:b52970891f84b67645c451c414d852f6642c9e9c73cf1eac21da4c5ef1063a6c5e8149452a6c3a0c8db7462a3c141220047b0c7e7bc7979f6ebe8da0b3a81b32
   - SHA256:49c149401f5f6357161ed14ef06a50f32b822da3b502fc8057995b9ea4ab3c2b
   - SHA1:77c335292fe19c0f04bd3901e2514089cabbd0b4 [weak]
   - MD5Sum:10c1d788d2095aaab106686f0a9754f2 [weak]
   - Filesize:104995956 [weak]
E: Failed to fetch http://apt.pop-os.org/proprietary/pool/jammy/main/binary-amd64/g/google-chrome-stable/google-chrome-stable_current_amd64.deb  File has unexpected size (104920896 != 104995956). Mirror sync in progress? [IP: 13.224.115.4 80]
   Hashes of expected file:
    - SHA512:b52970891f84b67645c451c414d852f6642c9e9c73cf1eac21da4c5ef1063a6c5e8149452a6c3a0c8db7462a3c141220047b0c7e7bc7979f6ebe8da0b3a81b32
    - SHA256:49c149401f5f6357161ed14ef06a50f32b822da3b502fc8057995b9ea4ab3c2b
    - SHA1:77c335292fe19c0f04bd3901e2514089cabbd0b4 [weak]
    - MD5Sum:10c1d788d2095aaab106686f0a9754f2 [weak]
    - Filesize:104995956 [weak]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

So, in the mean time, as we have a broken test suite, we'll go ahead with #12159

@andreslucena andreslucena added this to the 0.28.1 milestone Dec 20, 2023
@andreslucena andreslucena modified the milestones: 0.28.1, 0.28.2 Jan 10, 2024
github-actions[bot]
github-actions bot previously approved these changes Jan 29, 2024
github-actions[bot]
github-actions bot previously approved these changes Jan 29, 2024
@andreslucena
Copy link
Copy Markdown
Member Author

Closing this in favour of #12351

@andreslucena andreslucena deleted the fix/chrome-headless-syntax-with-120 branch January 30, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix PRs that implement a fix for a bug

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant