Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1207 +/- ##
==========================================
- Coverage 97.05% 97.04% -0.01%
==========================================
Files 424 424
Lines 7124 7147 +23
==========================================
+ Hits 6914 6936 +22
- Misses 210 211 +1
Continue to review full report at Codecov.
|
cc33de9 to
0bf5719
Compare
55b1ac2 to
8c268e6
Compare
|
@lastpotion, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mrcasals and @josepjaume to be potential reviewers. |
beagleknight
reviewed
Apr 6, 2017
| # Public: Generates a timepicker field using foundation | ||
| # datepicker library | ||
| def datetime_field(attribute, options = {}) | ||
| value = object.send(attribute) |
Contributor
There was a problem hiding this comment.
It would be nice to have some unit tests for this method.
Contributor
Author
There was a problem hiding this comment.
beagleknight
approved these changes
Apr 7, 2017
| @@ -1,4 +1,4 @@ | |||
| //@import compass | |||
| //@import compass | |||
Contributor
There was a problem hiding this comment.
Remove the whole comment.
oriolgual
approved these changes
Apr 7, 2017
josepjaume
approved these changes
Apr 10, 2017
1 task
This was referenced May 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR updates all the
date_fields, and adds a newdatetime_fieldto use the specificstyled foundation datepicker.
📌 Related Issues
📷 Screenshots (optional)
👻 GIF