Skip to content

Show message when there are no questions in survey#12065

Merged
alecslupu merged 1 commit intodevelopfrom
fix/surveys-empty
Dec 16, 2023
Merged

Show message when there are no questions in survey#12065
alecslupu merged 1 commit intodevelopfrom
fix/surveys-empty

Conversation

@andreslucena
Copy link
Copy Markdown
Member

@andreslucena andreslucena commented Nov 23, 2023

🎩 What? Why?

When there are no questions in a survey, we don't show any message, just a blank page.

This PR changes it to show a message.

I've found about this error while reviewing #11480.

📌 Related Issues

Testing

  1. Create a new process
  2. Create a survey component
  3. Allow answers for this survey
  4. Click in the "Preview" icon in the admin's component page
  5. See the page

📷 Screenshots

Screenshot of the no content page in surveys module

♥️ Thank you!

@andreslucena andreslucena added module: surveys type: fix PRs that implement a fix for a bug labels Nov 23, 2023
github-actions[bot]
github-actions bot previously approved these changes Nov 23, 2023
github-actions[bot]
github-actions bot previously approved these changes Nov 24, 2023
github-actions[bot]
github-actions bot previously approved these changes Nov 27, 2023
@andreslucena andreslucena marked this pull request as ready for review November 27, 2023 14:27
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: surveys type: fix PRs that implement a fix for a bug

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants