Do not show counters and filters when there isn't any election#12055
Do not show counters and filters when there isn't any election#12055
Conversation
|
Adding the |
alecslupu
left a comment
There was a problem hiding this comment.
There is a small issue with this PR:
Elections do have a warning callout but the others do not. Could we fix this ?
Budgets:
Debates
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
That's already solved. Can you check this out again @alecslupu ? |
alecslupu
left a comment
There was a problem hiding this comment.
Hey @andreslucena it seems this is actually more buggy than expected...
In my backend i have this:
In my frontend i have this:
When the component is barely published, the message is :
Maybe is something wrong with my dataset, but the list of finished meetings are appearing only if there is at least one upcomming meeting available.
|
@andreslucena It seems there are more issues on the elections page, and i am willing to merge this once we clarify how those 2 announcements should look like. |
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
We already have it in the mother key: - decidim.elections.warnings.no_scheduled_elections_warning Do we really need that extra warning?
69adce1 to
85ac517
Compare
You were right as usual 😄 Now it should be fixed, I added specs for each of the different announcements:
|
🎩 What? Why?
Related to #11875, on elections we're showing a message but we're also showing it with the counter and sorting controls. This PR changes it to not showing these controls to be consistent with the rest of modules.
📌 Related Issues
Testing
📷 Screenshots
Before
After