Skip to content

Add multiple statuses on proposals#12052

Merged
andreslucena merged 93 commits intodevelopfrom
feature/multiple-statuses-on-proposals
Feb 6, 2024
Merged

Add multiple statuses on proposals#12052
andreslucena merged 93 commits intodevelopfrom
feature/multiple-statuses-on-proposals

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Nov 21, 2023 •
edited
Loading

🎩 What? Why?

Please describe your pull request.

📌 Related Issues

Link your PR to an issue

Testing

  1. Reacreate your DB
  2. Visit proposals's index page in admin panel
  3. See there is a new button named "States"
  4. Edit and Add various states
  5. Go to Proposals answer page and add and answer, including new States.
  6. Publish the answer, and see is available in interface
  7. Also, you can use Proposal templates

📷 Screenshots

Please add screenshots of the changes you are proposing

image
image
image
image
image

♥️ Thank you!

@alecslupu
Add initial db structure
0661e9b
@alecslupu
Add build method
8964326
@alecslupu
Add proposal state model + admin presenter
2a01fb3
@alecslupu
Add proposal_state factory
460088b
@alecslupu
Add admin interface for proposal states
181baf1
@alecslupu
Misc changes
39cd3d4
@alecslupu
Fix proposal status
ccc9d28
@alecslupu
Running linters
4912248
@alecslupu
Fix failing Specs (#285)
afc9fd7
@alecslupu
Implement custom answers
dcb8185
@alecslupu
Fix proposal fields
d263f3e
@alecslupu
Merge branch 'fix/proposal-admin-fields' into feature/multiple-status…
631f2a3 
…es-on-proposals
@alecslupu
Fix the admin status badges
a5fe3a8
@alecslupu
Fix migration script
39215c6
@alecslupu
Add notifiable and anwerable to the proposal states
a4354f9
@alecslupu
Merge branch 'develop' of github.com:decidim/decidim into feature/mul…
e44c6fd 
…tiple-statuses-on-proposals
@alecslupu
Deprecating proposals old classes
482a83b
@alecslupu
Migrate frontend classes
c3ba8fd
@alecslupu
Refactor seeds
389ef1b
@alecslupu
Fix frontend
e3061fc
@alecslupu
Fix more tests
6afc92d
@alecslupu
Remove obsolete specs
555ff49
@alecslupu
Merge branch 'develop' of github.com:decidim/decidim into feature/mul…
d87e0c2 
…tiple-statuses-on-proposals
github-actions[bot]
github-actions bot requested changes Nov 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@alecslupu alecslupu added the type: change PRs that implement a change for an existing feature label Nov 21, 2023
github-actions[bot]
github-actions bot previously approved these changes Nov 21, 2023
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Nov 21, 2023
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Jan 31, 2024
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Feb 2, 2024
View reviewed changes
andreslucena
andreslucena requested changes Feb 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two really small changes in the migrations and we're good to merge

andreslucena
andreslucena reviewed Feb 6, 2024
View reviewed changes
decidim-proposals/app/controllers/concerns/decidim/proposals/admin/filterable.rb Outdated
end

def translated_proposal_state_id_eq(state_id)
translated_attribute(ProposalState.find_by(id: state_id)&.title)
Copy link
Copy Markdown
Member

@andreslucena andreslucena Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we apply this auto suggestion @alecslupu ?

@andreslucena andreslucena merged commit 93ec316 into develop Feb 6, 2024
@andreslucena andreslucena deleted the feature/multiple-statuses-on-proposals branch February 6, 2024 09:09
@alecslupu alecslupu mentioned this pull request Feb 9, 2024
Merged
@alecslupu alecslupu mentioned this pull request Jun 9, 2024
Closed
@NilHomedes NilHomedes mentioned this pull request Jun 19, 2024
Closed
6 tasks
@carolromero carolromero mentioned this pull request Jul 8, 2024
Open
@alecslupu alecslupu mentioned this pull request Jul 18, 2024
Merged
This was referenced Jul 26, 2024
Merged
Merged
Merged
Merged
@davidbeig davidbeig mentioned this pull request Oct 14, 2024
Merged
@fblupi fblupi mentioned this pull request Oct 21, 2024
Draft
@alexrlpz alexrlpz mentioned this pull request Nov 4, 2024
Closed
@alecslupu alecslupu mentioned this pull request Jan 23, 2025
Merged
@microstudi microstudi mentioned this pull request Jun 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreslucena andreslucena andreslucena approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@carolromero carolromero carolromero left review comments

Assignees

@andreslucena andreslucena

@carolromero carolromero

Labels

module: proposals

Projects

No open projects
Maintainers' backlog
Archived in project

Milestone

0.29.0

Development

Successfully merging this pull request may close these issues.

3 participants

@alecslupu @andreslucena @carolromero