Skip to content

Show error message when there are no posts in blogs#12013

Merged
alecslupu merged 4 commits intodevelopfrom
fix/blogs-no-results
Nov 18, 2023
Merged

Show error message when there are no posts in blogs#12013
alecslupu merged 4 commits intodevelopfrom
fix/blogs-no-results

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

When there are no posts in blogs, we don't show any message, just a blank page.

This PR changes it to show a message.

I've found about this error while reviewing #11480.

As I needed to change the indentation on the spec file, I recommend making the review on a commit by commit basis to see it better.

📌 Related Issues

Testing

  1. Create a new process
  2. Create a blogs component
  3. Click in the "Preview" icon in the admin's component page

📷 Screenshots

Screenshot of the no posts page in blogs module

♥️ Thank you!

@andreslucena andreslucena added module: blogs type: fix PRs that implement a fix for a bug labels Nov 16, 2023
github-actions[bot]
github-actions bot previously approved these changes Nov 16, 2023
@andreslucena andreslucena changed the title Show error message when there are no posts in blogs Show error message when there are no posts in blogs Nov 16, 2023
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: blogs type: fix PRs that implement a fix for a bug

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants