Merged
Conversation
alecslupu
suggested changes
Nov 14, 2023
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
@andreslucena, can you fix the failing pipelines ?
Contributor
|
@andreslucena maybe we should change the PR title so that it reflects better what you have done here? |
Member
Author
@alecslupu what do you have in mind? Maybe something like
? |
Contributor
The PR title you have set is ok for half of the work, but my issue would be with the refactor unrelated to endorsements... |
Contributor
|
@andreslucena I could not find a more suggestible name, so it is merged :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
In the last few days, there were a couple of issues and bugs that could be detected more easily if we had more endorsements in the Seeds:
This PR adds much more endorsements in the seeds
Mind that I'm doing this after all the seeds are created, so I can benefit from the large number of users.
Testing
Regenerating the
development_appdatabase should have much more endorsements in some resources:$ bin/rails db:drop db:create db:migrate db:seed📷 Screenshots