Skip to content

Remove code duplication in commands (part 3)#11971

Merged
andreslucena merged 6 commits intodevelopfrom
feature/user-call-standardization-3
Dec 15, 2023
Merged

Remove code duplication in commands (part 3)#11971
andreslucena merged 6 commits intodevelopfrom
feature/user-call-standardization-3

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Nov 7, 2023

🎩 What? Why?

Please describe your pull request.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@alecslupu alecslupu force-pushed the feature/user-call-standardization-3 branch 2 times, most recently from d726ac5 to b2f17b4 Compare November 7, 2023 22:26
@alecslupu alecslupu force-pushed the feature/user-call-standardization branch from 383055e to 1f25a2a Compare November 10, 2023 08:39
@andreslucena andreslucena self-assigned this Nov 10, 2023
@alecslupu alecslupu added the type: internal PRs that aren't necessary to add to the CHANGELOG for implementers label Dec 9, 2023
github-actions[bot]
github-actions bot previously approved these changes Dec 9, 2023
@alecslupu alecslupu force-pushed the feature/user-call-standardization-3 branch from b2f17b4 to fbb9c92 Compare December 10, 2023 17:26
@alecslupu alecslupu marked this pull request as ready for review December 10, 2023 19:07
Base automatically changed from feature/user-call-standardization to develop December 14, 2023 11:23
@andreslucena andreslucena dismissed github-actions[bot]’s stale review December 14, 2023 11:23

The base branch was changed.

@andreslucena andreslucena changed the title Remove code duplication in commands - Part 3 Remove code duplication in commands (part 3) Dec 14, 2023
github-actions[bot]
github-actions bot previously approved these changes Dec 14, 2023
github-actions[bot]
github-actions bot previously approved these changes Dec 14, 2023
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round

Comment thread decidim-budgets/app/commands/decidim/budgets/admin/create_order_reminders.rb Outdated
Comment thread decidim-debates/app/commands/decidim/debates/admin/close_debate.rb Outdated
Comment thread decidim-budgets/app/commands/decidim/budgets/admin/update_project.rb Outdated
Comment thread decidim-debates/app/commands/decidim/debates/update_debate.rb Outdated
Comment thread decidim-debates/app/commands/decidim/debates/admin/close_debate.rb Outdated
Comment thread decidim-budgets/spec/decidim/commands/destroy_resource_spec.rb Outdated
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
github-actions[bot]
github-actions bot previously approved these changes Dec 15, 2023
github-actions[bot]
github-actions bot previously approved these changes Dec 15, 2023
Copy link
Copy Markdown
Contributor Author

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my previous comment

Comment thread decidim-debates/app/commands/decidim/debates/admin/close_debate.rb Outdated
@andreslucena andreslucena merged commit 40129cf into develop Dec 15, 2023
@andreslucena andreslucena deleted the feature/user-call-standardization-3 branch December 15, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants