Skip to content

Remove code duplication in commands (part 2)#11970

Merged
andreslucena merged 7 commits intodevelopfrom
feature/user-call-standardization-2
Dec 15, 2023
Merged

Remove code duplication in commands (part 2)#11970
andreslucena merged 7 commits intodevelopfrom
feature/user-call-standardization-2

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Nov 7, 2023 •
edited
Loading

🎩 What? Why?

Please describe your pull request.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

@alecslupu alecslupu force-pushed the feature/user-call-standardization-2 branch from b9d6219 to da155c8 Compare November 7, 2023 18:00
github-actions[bot]
github-actions bot requested changes Nov 7, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@alecslupu alecslupu changed the title Add base resource handling commands Remove code duplication in commands - Part 2 Nov 7, 2023
@alecslupu alecslupu force-pushed the feature/user-call-standardization-2 branch 2 times, most recently from 8c0d080 to e67a2df Compare November 7, 2023 21:53
@alecslupu alecslupu force-pushed the feature/user-call-standardization branch from 383055e to 1f25a2a Compare November 10, 2023 08:39
@andreslucena andreslucena self-assigned this Nov 10, 2023
@alecslupu alecslupu force-pushed the feature/user-call-standardization-2 branch from e67a2df to 58991d9 Compare December 9, 2023 20:16
@alecslupu alecslupu marked this pull request as ready for review December 9, 2023 21:46
@alecslupu alecslupu added the type: internal PRs that aren't necessary to add to the CHANGELOG for implementers label Dec 9, 2023
github-actions[bot]
github-actions bot previously approved these changes Dec 9, 2023
View reviewed changes
@alecslupu alecslupu mentioned this pull request Dec 10, 2023
Merged
25 tasks
Base automatically changed from feature/user-call-standardization to develop December 14, 2023 11:23
@andreslucena andreslucena dismissed github-actions[bot]’s stale review December 14, 2023 11:23

The base branch was changed.

@andreslucena andreslucena changed the title Remove code duplication in commands - Part 2 Remove code duplication in commands (part 2) Dec 14, 2023
github-actions[bot]
github-actions bot previously approved these changes Dec 14, 2023
View reviewed changes
@alecslupu alecslupu force-pushed the feature/user-call-standardization-2 branch from 353117a to acbb859 Compare December 14, 2023 11:28
github-actions[bot]
github-actions bot previously approved these changes Dec 14, 2023
View reviewed changes
andreslucena
andreslucena requested changes Dec 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few details to change, mostly comments I think

Comment thread decidim-assemblies/app/commands/decidim/assemblies/admin/update_assemblies_type.rb
Comment thread decidim-blogs/app/commands/decidim/blogs/admin/update_post.rb Outdated
Comment thread decidim-assemblies/app/commands/decidim/assemblies/admin/create_assembly.rb Outdated
Comment thread decidim-assemblies/app/commands/decidim/assemblies/admin/update_assembly.rb Outdated
@alecslupu @andreslucena
Apply suggestions from code review
faa0592 
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@andreslucena andreslucena merged commit 395467b into develop Dec 15, 2023
@andreslucena andreslucena deleted the feature/user-call-standardization-2 branch December 15, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreslucena andreslucena andreslucena approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@andreslucena andreslucena

Labels

type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

No open projects
Maintainers' backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alecslupu @andreslucena