Skip to content

Redesign: accountability home empty content#11870

Merged
alecslupu merged 3 commits intodevelopfrom
fix/no-projects-accountability
Nov 6, 2023
Merged

Redesign: accountability home empty content#11870
alecslupu merged 3 commits intodevelopfrom
fix/no-projects-accountability

Conversation

@Crashillo
Copy link
Copy Markdown
Contributor

@Crashillo Crashillo commented Oct 30, 2023

🎩 What? Why?

Includes an empty message for each category depicted in the home page.

Co-author: @entantoencuanto

📌 Related Issues

📷 Screenshots

imagen
imagen

♥️ Thank you!

@Crashillo Crashillo added module: accountability type: fix PRs that implement a fix for a bug project: redesign Barcelona City Council contract labels Oct 30, 2023
@Crashillo Crashillo requested a review from a team October 30, 2023 17:00
github-actions[bot]
github-actions bot previously approved these changes Oct 30, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 31, 2023
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just going to say that we should add some specs, but before that I saw the "Refresh" button in GH 😄

Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost nailed it ...

When the category is too short, the fields do not appear to be aligned.
image

@alecslupu alecslupu self-assigned this Nov 1, 2023
@Crashillo Crashillo requested a review from alecslupu November 2, 2023 12:09
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
image

@alecslupu alecslupu merged commit 9b297d9 into develop Nov 6, 2023
@alecslupu alecslupu deleted the fix/no-projects-accountability branch November 6, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: accountability project: redesign Barcelona City Council contract type: fix PRs that implement a fix for a bug

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Redesign: accountability home headings repeated in mobile

3 participants