Conversation
|
Ok, sure. Just for the record, meeting and proposals (and most of the resources) use the layout_item type, however, blogs do not. Blogs is using the layout-1col (as the most of the forms, but not the resource items). Therefore, it does not apply the same section/spacing stuff, i.e the css behind the scenes is different. I'll make equal both gaps, good catch! :) |
andreslucena
left a comment
There was a problem hiding this comment.
We're pretty near but there are still three to be fixed: Proposals, Posts and (specially) Debates. Can you check them out?
This is what I've reviewed:
OK, they seem consistent between them
Initiative
Meeting
Result (Accountability)
Project (Budgets)
Not OK (too much gap)
Post (Blogs)
Proposal
Debate
Can you check the last three 🙏🏽 ?
|
That issue is due to the endorsers_list cell. Notice that the resources you say they're OK, have no Like button. This cell comes with three things:
Screencast.from.07-11-23.10.34.49.webmBig deal here is the endorsers_list. It is hidden until you click the small version of the list, but it cannot be absolute positioned since it comes: first, horizontally aligned with the tags in desktop but not in mobile; second, it could grow as much as it wants (i.e. many endorsers) overlapping the comments section. An easy solution (workaround) that comes to my mind now would be to increase the gap a lot. Similar to the current debates page. Doing this, you could add quite a lot endorsers "safely" (but the issue stills). Thoughts? |
I'd prefer to have the three of them as the Proposals/Posts page, as Debates is too big the gap. Also the solution of "let's add more space" doesn't work well, as we don't know how many endorsements could be there. For instance, generating multiple Endorsements I can make this gap big in a Proposal: As a participant, it doesn't make sense to have this gap. It only makes sense when we open the endorsers list: You can reproduce it locally with this small snippet: resource = Decidim::Endorsement.first.resource
Decidim::User.all.each do |author|
Decidim::Endorsement.create!(resource:, author:)
rescue StandardError
endAnd then visit the page of this resource. As that's not a quick fix, I propose to:
|
Uff, that's problematic. Debates is OK, as uses the same layout as the rest of the resources. The issue comes when the content is smaller than the aside. Look at the following screenshot: Since the layout item is a grid, when the aside block is larger than the main content, it forces this one to stretch. Once the main content includes more text, such gap comes back to "normal". So, that big gap will come up always that the main content is smaller than the aside block. |
Ah Ok, I thought it was something weird happening here but I can see the same behavior in other resources too as you mentioned. |
andreslucena
left a comment
There was a problem hiding this comment.
There where two pending things that I've mentioned in my last messages:
- the Debates show page bug: it's more difficult to solve than what I've initially thought, as @Crashillo mentioned it's actually a "too short" content situation that also happens in other resources. For the moment I think we can ignore it.
- the Endorsements situation with the blank space: it was solved with #11991
So, on my side this is ready to be merged. Thanks @Crashillo for your explanations and fixes 👏🏽 👏🏽
|
Adding the |
the meetings margin was solved already
|
As this is assigned to @alecslupu and he already gave a review, he'll have the final merge power on this PR. |















🎩 What? Why?
Include margin for comments in mobile
📷 Screenshots
Before:

After:
