Skip to content

Deletion of leftovers ZIP files in tmp directory#11527

Merged
alecslupu merged 4 commits intodecidim:developfrom
greenwoodt:fix/DownloadYourData-export-job
Aug 27, 2023
Merged

Deletion of leftovers ZIP files in tmp directory#11527
alecslupu merged 4 commits intodecidim:developfrom
greenwoodt:fix/DownloadYourData-export-job

Conversation

@greenwoodt
Copy link
Copy Markdown
Member

@greenwoodt greenwoodt commented Aug 25, 2023

🎩 What? Why?

Added method along with path to allow ZIP files to be deleted after export job in the tmp directory.

📌 Related Issues

Link your PR to an issue

Testing

  1. As user, ask for your data export
  2. Check the ZIP filename in the received mail
  3. See the remaining ZIP file in "tmp" folder has been deleted.

An Rspec test has been added to decidim-core/spec/jobs/decidim/download_your_data_export_job_spec.rbto test this feature.

📷 Screenshots

♥️ Thank you!

@greenwoodt greenwoodt added module: core backport Pull Requests that are a backport for a fixed bug type: fix PRs that implement a fix for a bug labels Aug 25, 2023
@greenwoodt greenwoodt self-assigned this Aug 25, 2023
@alecslupu alecslupu removed the backport Pull Requests that are a backport for a fixed bug label Aug 25, 2023
@alecslupu alecslupu added this to the 0.28.0 milestone Aug 25, 2023
@greenwoodt greenwoodt requested a review from alecslupu August 25, 2023 15:00
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: core type: fix PRs that implement a fix for a bug

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

DownloadYourData export job : leftovers zip files in tmp directory

2 participants