Conversation
81989f1 to
9f170e3
Compare
alecslupu
suggested changes
Aug 27, 2023
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
I see there are some issues.
- skip_to_id does not do what i expect to do ( either scroll the page to the specified element, or move the tab selection )
- there are some filters that are not preserved while searching / browsing using filters
- there are referenced some elements that have the opportunity not to exist in the page.
decidim-assemblies/app/views/decidim/assemblies/assemblies/index.html.erb
Outdated
Show resolved
Hide resolved
decidim-debates/app/views/decidim/debates/debates/index.html.erb
Outdated
Show resolved
Hide resolved
decidim-elections/app/views/decidim/votings/votings/index.html.erb
Outdated
Show resolved
Hide resolved
...y_processes/app/views/decidim/participatory_processes/participatory_processes/index.html.erb
Outdated
Show resolved
Hide resolved
alecslupu
suggested changes
Sep 10, 2023
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
One tiny additional detail. And we are good to go
alecslupu
approved these changes
Sep 13, 2023
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
Since the last element revealed will be tackled in another PR we are good to go with this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Restore the help text for the filters
📌 Related Issues
📷 Screenshots
https://decidim-redesign.populate.tools/processes/