Redesign: account menu & search mobile#11050
Conversation
f3865e7 to
896cb04
Compare
|
Ready to review |
decidim-core/app/views/layouts/decidim/header/_redesigned_main_links_mobile_account.html.erb
Show resolved
Hide resolved
82ad1b6 to
9e93cf0
Compare
|
@Crashillo the failing spec is an accessibility one, could you check? |
|
|
Ping @decidim/product |
There was a problem hiding this comment.
- @Crashillo before moving on let's fix notifications view in mobile:
carolromero
left a comment
There was a problem hiding this comment.
@Crashillo I don't get why but, now the push notifications text is mounted 🤷♀️.
Can we increase a little the space between the two? Thanks!
|
@Crashillo the failing specs at Core block are related with the markup you changed |
|
Fixed @decidim/product 
I'll go on asking @decidim/maintainers for review. |
|
The radio buttons in the My interests is not showing as it should (I see there is not enough space for the white / red circle ) : as compared with the notification settings: |
|
The menu looks strange only on the Groups page: as compared with the menu on Authorization page |
|
Not related to this ticket,, but i have seen that on mobile, there is a horizontal scrollbar on the Activity / Badges / Follows: (I am thinking that at least when using English not to have scrollbars) On Spanish is even worse ... |
alecslupu
left a comment
There was a problem hiding this comment.
Neat !
I have posted 3 comments, but only one needs to be tackled before merging: #11050 (comment)
The other 2, could be handled as stand alone tickets.
|
I've fixed both #11050 (comment) and #11050 (comment) |
🎩 What? Why?
Includes a mobile account menu. Due to current tech limitations, this menu will contain only the same items as the desktop account dropdown menu has.
Besides, the mobile search overlay is included also.
📌 Related Issues
📷 Screenshots
https://decidim-redesign.populate.tools/