Backport 'Fix notifications page when vapid is not available' to v0.27#10940
Merged
andreslucena merged 4 commits intorelease/0.27-stablefrom Jun 15, 2023
Merged
Conversation
dcda433 to
fd5f703
Compare
* User's group endorsement no longer disappears after personal endorsement removed * Fixed group endorsement removal when personal endorsement removed & tests * test-fixes * Fix the notification settings when vapid keys are not present --------- Co-authored-by: JoonasAapro <110532525+JoonasAapro@users.noreply.github.com>
fd5f703 to
dd3bb5f
Compare
andreslucena
requested changes
Jun 15, 2023
Member
andreslucena
left a comment
There was a problem hiding this comment.
I see that there are some changes that seems that have not relation to this particular PR (on .github/actions/module-rspec/action.yml and also on the Gemfile.lock files. Is that intentional? There was a failing spec related to those?
Contributor
Author
|
I don't know, @alecslupu has force pushed to this branch which overrides the original changes. Maybe Alex can take on this? |
Contributor
On it. There were some issues on the rubocop side, and also on the Gemfile ... |
andreslucena
approved these changes
Jun 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Backport #10286 to v0.27