Fix edge case in initiative creation#10723
Merged
Conversation
fb4e029 to
0c78597
Compare
ahukkanen
requested changes
Apr 15, 2023
Contributor
ahukkanen
left a comment
There was a problem hiding this comment.
The fix works as described for the case described in the PR description.
However, if I login again and go to the URL /create_initiative/fill_data, I still get the same 500 error that was there before.
This was referenced Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
There is an edge case in the initiatives wizard, when having a single initiative type available, and the user's session expires, then the initiative wizard will throw an 500 error, instead of redirecting the user to login.
This issues has been found while working on #10467
Testing
/create_initiative/fill_data