Skip to content

Upgrade node from 16.9.1 to 16.13.0#10701

Merged
fblupi merged 5 commits intodevelopfrom
chore/update-node
Apr 12, 2023
Merged

Upgrade node from 16.9.1 to 16.13.0#10701
fblupi merged 5 commits intodevelopfrom
chore/update-node

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Apr 10, 2023 •
edited
Loading

🎩 What? Why?

This PR upgrades the Node requirement to 16.10.0, as the github actions are dumping 49 log entries like:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@jest/console@29.5.0',
npm WARN EBADENGINE   required: { node: '^14.15.0 || ^16.10.0 || >=18.0.0' },
npm WARN EBADENGINE   current: { node: 'v16.9.1', npm: '7.21.1' }
npm WARN EBADENGINE }

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Ensure the pipeline is green, and no logs are being displayed.

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

@alecslupu alecslupu changed the title Upgrade node from 16.9.1 to 16.10.0 Upgrade node from 16.9.1 to 16.13.0 Apr 10, 2023
alecslupu
alecslupu commented Apr 11, 2023
View reviewed changes
@alecslupu alecslupu requested a review from a team April 11, 2023 15:48
@alecslupu alecslupu marked this pull request as ready for review April 11, 2023 15:48
fblupi
fblupi requested changes Apr 12, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@fblupi fblupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Searching for 16.9.1 I see other occurrences we should change too:

  • .gitpod.Dockerfile
  • decidim-generators/lib/decidim/generators/component_templates/github

And some other package.json and package-lock.json where the engine requires node >= 16.9.1

@alecslupu alecslupu requested a review from fblupi April 12, 2023 12:40
@fblupi fblupi merged commit 82b1336 into develop Apr 12, 2023
@fblupi fblupi deleted the chore/update-node branch April 12, 2023 15:00
@andreslucena andreslucena added target: developer-experience dependencies Pull requests that update a dependency file or issues that talk about updating dependencies type: internal PRs that aren't necessary to add to the CHANGELOG for implementers labels Apr 21, 2023
@andreslucena
Copy link
Copy Markdown
Member

andreslucena commented Apr 21, 2023

FYI, I've added the labels as they were missing. They're important because if not when we generate the changelog, will need to manually add it at that moment.

Also, on another related topic:

I see that the last minor version from node 16 is v16.20.0, any reason why we didn't migrate to that version? It was released the 28/03/2023.

@alecslupu
Copy link
Copy Markdown
Contributor Author

alecslupu commented Apr 21, 2023 •
edited
Loading

FYI, I've added the labels as they were missing. They're important because if not when we generate the changelog, will need to manually add it at that moment.

Also, on another related topic:

I see that the last minor version from node 16 is v16.20.0, any reason why we didn't migrate to that version? It was released the 28/03/2023.

The focus was on removing the deprecation messages, keeping the lowest version available. The plan is to revisit all the npm packages in the upcoming period, and perform all the possible upgrades, including the npm to the last version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fblupi fblupi fblupi approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file or issues that talk about updating dependencies target: developer-experience type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alecslupu @andreslucena @fblupi