Conversation
ahukkanen
requested changes
Apr 6, 2023
Contributor
There was a problem hiding this comment.
There are also other places where you can find similar uses:
$ grep -rP "var\(--[a-z]+-rgb\)" decidim-*/app/packs/stylesheets
decidim-core/app/packs/stylesheets/decidim/vizzs/_areachart.scss: fill: rgba(var(--primary-rgb), .05);
decidim-core/app/packs/stylesheets/decidim/vizzs/_areachart.scss: stroke: rgba(var(--primary-rgb), .2);
decidim-core/app/packs/stylesheets/decidim/vizzs/_areachart.scss: fill: rgba(var(--primary-rgb), .2);
decidim-core/app/packs/stylesheets/decidim/modules/_floating-helper.scss: background-color: rgba(var(--secondary-rgb), .1);
decidim-core/app/packs/stylesheets/decidim/modules/_floating-helper.scss: background-color: rgba(var(--secondary-rgb), .1);
decidim-core/app/packs/stylesheets/decidim/modules/_floating-helper.scss: background-color: rgba(var(--secondary-rgb), .1);
decidim-core/app/packs/stylesheets/decidim/modules/_navbar.scss: background-color: rgba(var(--secondary-rgb), .05);
decidim-core/app/packs/stylesheets/decidim/modules/_process-nav.scss: background-color: rgba(var(--primary-rgb), .1);
decidim-meetings/app/packs/stylesheets/decidim/meetings/_main.scss: background-color: rgba(var(--warning-rgb), .1);I'm thinking should we rather fix the -rgb values? Is there any reason preserving the legacy format?
ahukkanen
requested changes
Apr 6, 2023
Contributor
ahukkanen
left a comment
There was a problem hiding this comment.
Do we need the SCSS change if we fix the values?
decidim-core/app/packs/stylesheets/decidim/vizzs/_areachart.scss
Outdated
Show resolved
Hide resolved
ahukkanen
approved these changes
Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR makes use of `--primary`` variable to display the metrics in a pretty form.
📌 Related Issues
Link your PR to an issue
Testing
📷 Screenshots
Please add screenshots of the changes you are proposing
Before:
After:
Revert #10424:
