Skip to content

Install prettier formatter#10669

Merged
fblupi merged 5 commits intodevelopfrom
chore/add-prettier
Apr 5, 2023
Merged

Install prettier formatter#10669
fblupi merged 5 commits intodevelopfrom
chore/add-prettier

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Mar 31, 2023

🎩 What? Why?

Since we have upgraded the stylelint to 15.x, we could observe that some of the rules that we were using, were deprecated in favor of Prettier.

From the stylelint release notes:

When we created these rules, pretty printers (like Prettier) didn't exist. They now offer a better way to consistently format code, especially whitespace. Linters and pretty printers are complementary tools that work together to help you write consistent and error-free code.

The Prettier will fail if the SCSS is not formatted as it is expected. This is also enforced at the pipeline level, like the below run

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

@alecslupu alecslupu force-pushed the chore/add-prettier branch from 3564580 to 664f405 Compare March 31, 2023 22:32
@alecslupu alecslupu changed the title Chore/add prettier Install prettier formatter Mar 31, 2023
@alecslupu alecslupu changed the base branch from develop to chore/upgrade-stylelint March 31, 2023 22:38
@alecslupu alecslupu force-pushed the chore/add-prettier branch from 664f405 to c40a8bd Compare April 1, 2023 06:20
@alecslupu alecslupu added the type: change PRs that implement a change for an existing feature label Apr 1, 2023
@alecslupu alecslupu force-pushed the chore/upgrade-stylelint branch from b811028 to 8fbe577 Compare April 1, 2023 11:04
Base automatically changed from chore/upgrade-stylelint to develop April 4, 2023 10:03
@alecslupu alecslupu force-pushed the chore/add-prettier branch from 8daaf1e to 0990c49 Compare April 4, 2023 15:20
@alecslupu alecslupu marked this pull request as ready for review April 5, 2023 10:53
@fblupi fblupi merged commit 55e02b0 into develop Apr 5, 2023
@fblupi fblupi deleted the chore/add-prettier branch April 5, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: change PRs that implement a change for an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants