Skip to content

Improve the link handling#10611

Merged
alecslupu merged 16 commits intodevelopfrom
fix/improve-link-handling
Apr 5, 2023
Merged

Improve the link handling#10611
alecslupu merged 16 commits intodevelopfrom
fix/improve-link-handling

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

🎩 What? Why?

Improve link handling of the redirect engine.

📌 Related Issues

Testing

Describe the best way to test or validate your PR.

♥️ Thank you!

@alecslupu alecslupu marked this pull request as ready for review March 22, 2023 09:30
@alecslupu alecslupu requested a review from a team March 25, 2023 00:03
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one helper defined which I don't see existing or used anywhere.

Comment thread decidim-core/app/controllers/decidim/links_controller.rb Outdated
Comment thread decidim-core/app/helpers/decidim/external_domain_helper.rb Outdated
@alecslupu alecslupu requested a review from ahukkanen March 31, 2023 21:39
@alecslupu alecslupu merged commit c39a748 into develop Apr 5, 2023
@alecslupu alecslupu deleted the fix/improve-link-handling branch April 5, 2023 08:15
@andreslucena andreslucena added the type: fix PRs that implement a fix for a bug label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: core team: security type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants