This is a Bug Report
🎩 Description
I see an excesive white space on top of the list of endorsements for a proposal. It seems like that whitespace is controlled by the height of the sidebar, which seems unexpected, since adding things to the sidebar will keep unintentionally increasing the whitespace...
Setting height: 0 on the sidebar seems to do the trick on my browser, not sure what consequences that could have. However, the list of endorsements seemed "out of the markup structure" to me, the following patch in the template also had a similar visual effect of removing the whitespace. Not sure if that could have other negative consequences or break anything:
diff --git a/decidim-proposals/app/views/decidim/proposals/proposals/show.html.erb b/decidim-proposals/app/views/decidim/proposals/proposals/show.html.erb
index 5a0e141fc..7216f4522 100644
--- a/decidim-proposals/app/views/decidim/proposals/proposals/show.html.erb
+++ b/decidim-proposals/app/views/decidim/proposals/proposals/show.html.erb
@@ -90,12 +90,16 @@
<%= linked_resources_for @proposal, :projects, "included_proposals" %>
<%= linked_resources_for @proposal, :meetings, "proposals_from_meeting" %>
<%= linked_resources_for @proposal, :proposals, "copied_from_component" %>
+
+ <div class="section">
+ <a name="list-of-endorsements"></a>
+ <%= render partial: 'endorsements_listing', locals: {proposal: @proposal} %>
+ </div>
</div>
</div>
+
<%= attachments_for @proposal %>
-<a name="list-of-endorsements"></a>
-<%= render partial: 'endorsements_listing', locals: {proposal: @proposal} %>
<%= comments_for @proposal %>
<%= javascript_include_tag "decidim/proposals/social_share" %>📌 Related issues
📋 Additional Data
I can only reproduce this issue on chromium, but doesn't happen on firefox or chrome. Not sure about other browsers.
This is a Bug Report
🎩 Description
I see an excesive white space on top of the list of endorsements for a proposal. It seems like that whitespace is controlled by the height of the sidebar, which seems unexpected, since adding things to the sidebar will keep unintentionally increasing the whitespace...
Setting
height: 0on the sidebar seems to do the trick on my browser, not sure what consequences that could have. However, the list of endorsements seemed "out of the markup structure" to me, the following patch in the template also had a similar visual effect of removing the whitespace. Not sure if that could have other negative consequences or break anything:📌 Related issues
📋 Additional Data
I can only reproduce this issue on chromium, but doesn't happen on firefox or chrome. Not sure about other browsers.