Skip to content

Wrong markup for hide this content on report form #11433

@alecslupu

Description

@alecslupu

Describe the bug

Currently, the markup for hiding content seems to be wrongly implemented in the redesign:
This is implemented:

<fieldset>
                <div class="modal__report-container__radio">
                  <input data-label-action="Hide" data-label-report="Report" data-hide="true" id="c3dffb30f0f76c7e73db15e0668c4940" type="checkbox" value="1" name="report[hide]">
                  <label for="c3dffb30f0f76c7e73db15e0668c4940">
                    Hide this content
                  </label>
                </div>
              </fieldset>

and outputs the following output :
image

A more appropriate implementation would be

<fieldset>
                 
                  <label for="d609de5bafe3a02fe4b4a082bedbe3d8" class="form__wrapper-checkbox-label">
                    <input data-label-action="Hide" data-label-report="Report" data-hide="true" id="d609de5bafe3a02fe4b4a082bedbe3d8" type="checkbox" value="1" name="report[hide]">
                    Hide this content
                  </label>
              </fieldset>

image

To Reproduce

  1. Go to any proposal
  2. Click report
  3. see error

Expected behavior

Display the Hide this content in a more nicer way, that would be fit for the new redesign.

Screenshots

No response

Stacktrace

No response

Extra data

  • Decidim Version: DEV
  • Decidim installation: Local

Additional context

No response

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions