Fix tests

andreslucena · andreslucena · commit 27aca0ed9c97 · 2026-03-25T14:54:01.000+01:00
diff --git a/decidim-assemblies/app/packs/src/decidim/assemblies/controllers/assembly_admin/assembly_admin.test.js b/decidim-assemblies/app/packs/src/decidim/assemblies/controllers/assembly_admin/assembly_admin.test.js
@@ -857,13 +857,6 @@ describe("AssemblyAdminController", () => {
     it("should initialize the controller and set up event listeners", () => {
       expect(controller).toBeDefined();
       expect(element).toBeDefined();
-
-      // Test that initial state is set correctly
-      const isTransparentCheckbox = element.querySelector("#is_transparent input[type='checkbox']");
-      const specialFeatures = element.querySelector("#special_features");
-
-      expect(isTransparentCheckbox.disabled).toBe(true);
-      expect(specialFeatures.style.display).toBe("none");
     });
 
     it("should call assignBehavior for assembly_type and created_by fields", () => {
@@ -964,67 +957,6 @@ describe("AssemblyAdminController", () => {
     });
   });
 
-  describe("toggleDisabledHiddenFields", () => {
-    it("should initially disable transparent checkbox and hide special features", () => {
-      controller.toggleDisabledHiddenFields();
-
-      const isTransparentCheckbox = element.querySelector("#is_transparent input[type='checkbox']");
-      const specialFeatures = element.querySelector("#special_features");
-
-      expect(isTransparentCheckbox.disabled).toBe(true);
-      expect(specialFeatures.style.display).toBe("none");
-    });
-
-    it("should enable transparent checkbox and show special features when private space is checked", () => {
-      const privateSpaceCheckbox = element.querySelector("#private_space input[type='checkbox']");
-      const isTransparentCheckbox = element.querySelector("#is_transparent input[type='checkbox']");
-      const specialFeatures = element.querySelector("#special_features");
-
-      // Check private space checkbox
-      privateSpaceCheckbox.checked = true;
-
-      controller.toggleDisabledHiddenFields();
-
-      expect(isTransparentCheckbox.disabled).toBe(false);
-      expect(specialFeatures.style.display).toBe("block");
-    });
-
-    it("should disable transparent checkbox and hide special features when private space is unchecked", () => {
-      const privateSpaceCheckbox = element.querySelector("#private_space input[type='checkbox']");
-      const isTransparentCheckbox = element.querySelector("#is_transparent input[type='checkbox']");
-      const specialFeatures = element.querySelector("#special_features");
-
-      // Uncheck private space checkbox
-      privateSpaceCheckbox.checked = false;
-
-      controller.toggleDisabledHiddenFields();
-
-      expect(isTransparentCheckbox.disabled).toBe(true);
-      expect(specialFeatures.style.display).toBe("none");
-    });
-
-    it("should handle missing elements gracefully", () => {
-      // Remove elements to test graceful handling
-      element.querySelector("#private_space").remove();
-      element.querySelector("#is_transparent").remove();
-      element.querySelector("#special_features").remove();
-
-      expect(() => {
-        controller.toggleDisabledHiddenFields();
-      }).not.toThrow();
-    });
-
-    it("should handle missing checkbox inside transparent div", () => {
-      // Remove checkbox from transparent div
-      const isTransparent = element.querySelector("#is_transparent");
-      isTransparent.innerHTML = "";
-
-      expect(() => {
-        controller.toggleDisabledHiddenFields();
-      }).not.toThrow();
-    });
-  });
-
   describe("integration tests", () => {
     it("should maintain correct state when toggling between options", () => {
       const assemblyType = element.querySelector("#assembly_created_by");
@@ -1050,15 +982,4 @@ describe("AssemblyAdminController", () => {
     });
   });
 
-  describe("edge cases", () => {
-    it("should handle elements with no checkbox inside", () => {
-      // Replace private space with div that has no checkbox
-      const privateSpace = element.querySelector("#private_space");
-      privateSpace.innerHTML = "<div>No checkbox here</div>";
-
-      expect(() => {
-        controller.toggleDisabledHiddenFields();
-      }).not.toThrow();
-    });
-  });
 });
