Fix rubocop offenses

andreslucena · andreslucena · commit 0b7a9200fc1f · 2026-03-06T16:26:18.000+01:00
diff --git a/decidim-admin/spec/cells/decidim/admin/homepage_content_block_cell_spec.rb b/decidim-admin/spec/cells/decidim/admin/homepage_content_block_cell_spec.rb
@@ -5,11 +5,11 @@
 describe Decidim::Admin::HomepageContentBlockCell, type: :cell do
   controller Decidim::Admin::OrganizationHomepageController
 
+  subject { cell("decidim/admin/homepage_content_block", content_block).call }
+
   let(:organization) { create(:organization) }
   let(:content_block) { create(:content_block, organization:, manifest_name: :hero, scope_name: :homepage) }
 
-  subject { cell("decidim/admin/homepage_content_block", content_block).call }
-
   it "renders the content block name" do
     expect(subject).to have_content("Hero image")
   end
@@ -30,8 +30,8 @@
     let(:content_block) { build(:content_block, organization:, manifest_name: :hero, scope_name: :homepage) }
 
     it "does not render edit or destroy links" do
-      expect(subject).not_to have_link(href: %r{/content_blocks/\d+/edit$})
-      expect(subject).not_to have_css('a[data-method="delete"]')
+      expect(subject).to have_no_link(href: %r{/content_blocks/\d+/edit$})
+      expect(subject).to have_no_css('a[data-method="delete"]')
     end
   end
 
@@ -41,7 +41,7 @@
     end
 
     it "does not render edit link" do
-      expect(subject).not_to have_link(href: /edit/)
+      expect(subject).to have_no_link(href: /edit/)
     end
   end
 end
diff --git a/decidim-admin/spec/system/admin_publishes_unpublishes_content_blocks_spec.rb b/decidim-admin/spec/system/admin_publishes_unpublishes_content_blocks_spec.rb
@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-describe "Admin publishes/unpublishes content blocks", type: :system do
+describe "Admin publishes/unpublishes content blocks" do
   let(:organization) { create(:organization) }
   let(:user) { create(:user, :admin, :confirmed, organization:) }
 
@@ -54,7 +54,7 @@
       expect(hero_block.reload.published_at).to be_nil
 
       visit decidim.root_path
-      expect(page).not_to have_css("[id^=hero]")
+      expect(page).to have_no_css("[id^=hero]")
     end
   end
 end
diff --git a/decidim-core/spec/system/homepage_content_blocks_spec.rb b/decidim-core/spec/system/homepage_content_blocks_spec.rb
@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-describe "Homepage with content blocks", type: :system do
+describe "Homepage with content blocks" do
   let(:official_url) { "http://test.example.org" }
   let(:organization) { create(:organization, official_url:) }
   let!(:participatory_process) { create(:participatory_process, :promoted, organization:) }
@@ -42,10 +42,10 @@
     visit decidim.root_path
 
     hero_section = page.find("section.hero__container")
-    sub_hero_section = page.find("#sub_hero")
-    how_to_participate_section = page.find("#how_to_participate")
-    stats_section = page.find("#statistics")
-    footer_sub_hero_section = page.find("#footer_sub_hero")
+    sub_hero_section = page.find_by_id("sub_hero")
+    how_to_participate_section = page.find_by_id("how_to_participate")
+    stats_section = page.find_by_id("statistics")
+    footer_sub_hero_section = page.find_by_id("footer_sub_hero")
 
     hero_position = hero_section.evaluate_script("this.getBoundingClientRect().top")
     sub_hero_position = sub_hero_section.evaluate_script("this.getBoundingClientRect().top")
