feat: add loading feedback to deploy preview button#7757
Merged
martinjagodic merged 1 commit intodecaporg:mainfrom Mar 17, 2026
Merged
feat: add loading feedback to deploy preview button#7757martinjagodic merged 1 commit intodecaporg:mainfrom
martinjagodic merged 1 commit intodecaporg:mainfrom
Conversation
Show a spinning refresh icon and disable the button while deploy preview polling is in progress (isFetching: true). This gives editors clear visual feedback that the system is checking for a preview. Also increases maxAttempts from 3 to 15 after save (~75s polling window), giving CI pipelines enough time to post commit statuses before giving up. Uses a transient prop ($spinning) to avoid leaking non-standard attributes to the DOM.
6588ef6 to
70477f8
Compare
yanthomasdev
approved these changes
Mar 16, 2026
Contributor
yanthomasdev
left a comment
There was a problem hiding this comment.
Thanks @jonasbeck, looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds visual loading feedback to the "Check for Preview" button while deploy preview polling is in progress.
Changes
Spinning refresh icon
When
isFetchingis true, the refresh icon on the "Check for Preview" button spins with a CSS animation, giving editors clear visual feedback that the system is actively checking for a preview.Disabled during polling
The button is disabled while polling is in progress, preventing duplicate requests from stacking up.
Transient prop
Uses
$spinning(Emotion transient prop) to avoid leaking non-standard attributes to the DOM.UX flow