Skip to content

feat: add loading feedback to deploy preview button#7757

Merged
martinjagodic merged 1 commit intodecaporg:mainfrom
jonasbeck:feat/deploy-preview-loading-feedback
Mar 17, 2026
Merged

feat: add loading feedback to deploy preview button#7757
martinjagodic merged 1 commit intodecaporg:mainfrom
jonasbeck:feat/deploy-preview-loading-feedback

Conversation

@jonasbeck
Copy link
Copy Markdown
Contributor

@jonasbeck jonasbeck commented Mar 16, 2026

Summary

Adds visual loading feedback to the "Check for Preview" button while deploy preview polling is in progress.

Changes

Spinning refresh icon

When isFetching is true, the refresh icon on the "Check for Preview" button spins with a CSS animation, giving editors clear visual feedback that the system is actively checking for a preview.

Disabled during polling

The button is disabled while polling is in progress, preventing duplicate requests from stacking up.

Transient prop

Uses $spinning (Emotion transient prop) to avoid leaking non-standard attributes to the DOM.

UX flow

  1. Editor clicks "Check for Preview" or polling starts automatically
  2. Refresh icon spins, button is disabled
  3. When polling resolves, spinning stops and button either transitions to "View Preview" link or re-enables for manual retry

@jonasbeck jonasbeck requested a review from a team as a code owner March 16, 2026 19:34
@jonasbeck jonasbeck closed this Mar 16, 2026
@jonasbeck jonasbeck reopened this Mar 16, 2026
Show a spinning refresh icon and disable the button while deploy preview
polling is in progress (isFetching: true). This gives editors clear visual
feedback that the system is checking for a preview.

Also increases maxAttempts from 3 to 15 after save (~75s polling window),
giving CI pipelines enough time to post commit statuses before giving up.

Uses a transient prop ($spinning) to avoid leaking non-standard
attributes to the DOM.
@jonasbeck jonasbeck force-pushed the feat/deploy-preview-loading-feedback branch from 6588ef6 to 70477f8 Compare March 16, 2026 20:16
Copy link
Copy Markdown
Contributor

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonasbeck, looks good to me.

@martinjagodic martinjagodic merged commit 61d8b8b into decaporg:main Mar 17, 2026
10 checks passed
@jonasbeck jonasbeck deleted the feat/deploy-preview-loading-feedback branch March 17, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants