fix(lib-util): treat root-relative media paths as absolute#7650
Merged
martinjagodic merged 3 commits intodecaporg:mainfrom Nov 11, 2025
Merged
fix(lib-util): treat root-relative media paths as absolute#7650martinjagodic merged 3 commits intodecaporg:mainfrom
martinjagodic merged 3 commits intodecaporg:mainfrom
Conversation
Member
martinjagodic
left a comment
There was a problem hiding this comment.
The code is ok, but the unit test should handle double slashes is failing. Please make sure that double slashes are handled.
martinjagodic
approved these changes
Nov 3, 2025
martinjagodic
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #7639. In 3.8.4, isAbsolutePath stopped treating URLs like
/.attachments/foo.pngas absolute; as a result Decap rewrote them toassets/uploads/..., the preview switched to a blob: URL, and the Git API looked for the wrong filename. I updated the regex in path.ts so a leading slash counts as absolute again and those paths behave the same as before.Test plan
Checklist
Please add a
xinside each checkbox:A picture of a cute animal (not mandatory but encouraged)
