Skip to content

chore: use correct syntax for Node LTS#7600

Merged
martinjagodic merged 3 commits intodecaporg:mainfrom
jviall:jviall/fix-nvmrc
Nov 11, 2025
Merged

chore: use correct syntax for Node LTS#7600
martinjagodic merged 3 commits intodecaporg:mainfrom
jviall:jviall/fix-nvmrc

Conversation

@jviall
Copy link
Contributor

@jviall jviall commented Sep 12, 2025

Summary
Node version managers NVM and FNM allow for specifying a dynamic "LTS" version in the .nvmrc file, but the current syntax of --lts is incorrect (at least for FNM). This changes it to lts/* which resolves to the current latest LTS version

Test plan

  • Have a local clone of the repo on a system using either NVM or FNM without the current LTS of Node installed.
  • cd into the repo, and confirm installation of the specified version.

Checklist

Please add a x inside each checkbox:

A picture of a cute animal (not mandatory but encouraged)
a bumblebee napping
image

@jviall jviall requested a review from a team as a code owner September 12, 2025 17:19
@martinjagodic
Copy link
Member

@jviall did you test this with NVM?

@jviall
Copy link
Contributor Author

jviall commented Sep 15, 2025

@jviall did you test this with NVM?

I tested with FNM, not NVM, but happy to do so.

@martinjagodic
Copy link
Member

please do, it has to work with NVM too

@martinjagodic martinjagodic enabled auto-merge (squash) November 11, 2025 13:01
@martinjagodic martinjagodic merged commit 467b930 into decaporg:main Nov 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants