Fix relation control loading values#7556
Merged
martinjagodic merged 2 commits intomainfrom Jul 22, 2025
Merged
Conversation
… work correctly with debounce
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with the relation control widget where async function behavior conflicts with debounce functionality after a caching update in version 3.8. The solution changes the implementation from async/await syntax back to promise chaining within the debounced function.
Key Changes
- Converts
loadOptionsmethod from async/await to promise chaining to resolve debounce compatibility issues - Removes try/catch error handling block as part of the refactor
martinjagodic
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Seems like async function does not play nice with debounce after the caching update we did in 3.8. This is a patch that fixes this by using promise chaining again.
Test plan
Checklist
Please add a
xinside each checkbox:A picture of a cute animal (not mandatory but encouraged)