Closed
Conversation
add aria labels to improve accessibility
✅ Deploy Preview for decap-www canceled.
|
xaiki
reviewed
Oct 4, 2023
xaiki
left a comment
There was a problem hiding this comment.
my 2c review
note: i'm not part of the decap team.
| `} | ||
| > | ||
| <button | ||
| aria-label={'set '.concat(fieldName).concat(' to now')} |
There was a problem hiding this comment.
`set ${fieldName} to now`is probably more readable
Contributor
|
Thanks @kewitham, these are certainly valuable improvements. Given the state of the PR being so old and the repository changing a lot, I am actually unable to fix the conflicts without git crashing for me 😓, I have remade your changes in a new PR and credited you as an author, I hope that's OK! Due to that, I'll be closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Our team at ada.gov uses Netlify CMS. Recently Terri Youngblood, the accessibility consultant for the DOJ Civil Rights Section, did an audit of Netlify to verify its accessibility and identified some issues. This PR addresses those concerns - specifically aria-label updates.
Test plan
Verify that the buttons indicated now have labels that can be read by a screenreader.
Checklist
Please add a
xinside each checkbox:A picture of a cute animal (not mandatory but encouraged)
