Merged
Conversation
| port: 3306, | ||
| username: "", | ||
| database: "", | ||
| ssl_mode: "", |
There was a problem hiding this comment.
WARNING: State/UI mismatch - initial value is "" but UI shows "prefer"
The select at line 371 uses formData.ssl_mode || "prefer" which displays "prefer" as the default. However, the actual state value is an empty string, which gets sent to the backend and silently fails to parse (falling back to postgres default instead of "prefer").
Suggested change
| ssl_mode: "", | |
| ssl_mode: "prefer", |
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
The initial state sets Files Reviewed (3 files)
|
Owner
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #77