Fix Escape key handling for modals#66

Merged

debba merged 1 commit intodebba:mainfrom

SergioChan:fix/escape-close-modals

Mar 6, 2026

Contributor

SergioChan commented Mar 6, 2026

Summary

listen for Escape key events during capture to close the active modal reliably
prevent default Escape behavior when dismissing the modal

Testing

Not run (not requested)

Related

Fixes #62


          Fix Escape handling for modals

04aa497

Owner

debba commented Mar 6, 2026

Ho @SergioChan !

thanks for this, it was already fixed by me.
Did you encounter an edge case in which is not working?

Btw looks an improvement of mine.
Did you already test it?

Owner

debba commented Mar 6, 2026

@SergioChan tested and LGTM.
Thanks for contribution, hope you will continue to improve the product.
If you want you can join us on Discord (you can find the link in the Github project README)

debba merged commit 0b6d7a4 into debba:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet