Add support for SHA256 fingerprints#1343
Merged
p12tic merged 24 commits intodebauchee:masterfrom Nov 1, 2021
Merged
Conversation
a0ed334 to
2e56aa2
Compare
fopen() does not correctly handle non-ASCII paths on Windows.
The code has been copied from OpenSSH.
For the time being both SHA1 and SHA256 fingerprints will be shown in the UI. This allows users to verify new connections between old and new versions of Barrier. After the initial verification we use SHA256 fingerprints. The issue has been reported by Matthias Gerstner <mgerstner@suse.de>.
2e56aa2 to
a428b61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SHA1 fingerprints are no longer state of the art, switch to verifying SHA256 fingerprints.
For the time being both SHA1 and SHA256 fingerprints are shown in the UI. This allows users to verify new connections between old and new versions of Barrier. After the verification is done we store SHA256 fingerprint in our internal fingerprint database and use only that for identifying all future connections from that client.
The issue has been reported by Matthias Gerstner mgerstner@suse.de @mgerstner.