refactor: detect custom files in ddev utility diagnose#8279
Merged
Conversation
|
Download the artifacts for this pull request:
See Testing a PR.
|
Contributor
|
Codex verification: I reproduced this behavior locally with the PR branch binary. Repro 1: silenced file ddev config --project-name pr8279manual --project-type php --docroot .
mkdir -p .ddev/php
printf "#ddev-silent-no-warn\nmemory_limit = 256M\n" > .ddev/php/silenced.ini
ddev utility check-custom-config
ddev utility check-custom-config --all
ddev utility diagnoseOutput: Repro 2: add-on-managed files ddev config --project-name pr8279addon --project-type php --docroot .
ddev add-on get ./cmd/ddev/cmd/testdata/TestUtilityCheckCustomConfigCmd/mock-myservice
ddev utility check-custom-config
ddev utility check-custom-config --all
ddev utility diagnoseOutput: So |
Member
|
I do wonder why we haven't started using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
There's a new command added in:
ddev utility check-custom-config#8218We already use it in
ddev utility testbut not inddev utility diagnose.How This PR Solves The Issue
Refactors the logic to use
ddev utility check-custom-config --allinsideddev utility diagnoseManual Testing Instructions
Check the output for customizations:
ddev utility diagnose ddev dotenv set .ddev/.env --test-env=true ddev utility diagnoseAutomated Testing Overview
Release/Deployment Notes