Set version constraint for docker-compose to current, fixes #4135#4142
Merged
rfay merged 5 commits intoddev:masterfrom Aug 24, 2022
Merged
Set version constraint for docker-compose to current, fixes #4135#4142rfay merged 5 commits intoddev:masterfrom
rfay merged 5 commits intoddev:masterfrom
Conversation
|
Download the artifacts for this pull request: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
As of v1.21.1, docker-compose v1 is not allowed, but the docker-compose version constraint was not updated
How this PR Solves The Problem:
Update the version constraint, check it on start, and explain what to do about it.
Manual Testing Instructions:
ddev config global --use-docker-compose-from-pathddev startSee explanatory error message.