Conversation
Contributor
Author
|
still need to address the vault client for databag retrieval |
2 tasks
added 2 commits
February 3, 2017 17:17
Contributor
Author
|
I haven't done all the name cleanup, just enough to get the tests running. |
rfay
requested changes
Feb 4, 2017
Member
rfay
left a comment
There was a problem hiding this comment.
This is still building into a tool named "drud", so that will need to be changed, and of course it affects the tests dramatically.
Member
|
I'd be happy to install the build tools and get them going, but don't want to do it when you have something this big WIP. If you want me to do it in this branch I can, as long as we're clear who's working when. |
https://github.com/drud/bootstrap/commit/cc474cb4985713b14f2aeadfd279ff638d92d6cb Significantly massaged to work here - several files were removed. Author: Tanner J Ferguson <tannerjfco@gmail.com> Date: Fri Feb 3 13:23:43 2017 -0700 Improves Cli validation (#261) * removes duplicate add of LocalDevCmd * adds validation for hosting resources * return usage on empty host subcmd * return usage on empty sub cmds, return usage on root cmd * make template flag required for hosting app create * adds validation for config cmds * removes empty Run declarations on parent cmds so they return usage * removes run from backup cmd, removes subCmdUsage
1 task
10 tasks
1 task
1 task
1 task
1 task
1 task
1 task
1 task
Closed
1 task
1 task
1 task
4 tasks
4 tasks
4 tasks
4 tasks
4 tasks
4 tasks
Closed
4 tasks
4 tasks
4 tasks
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem:
Drud dev needs to be open sourced but is currently embedded within a largely closed source codebase.
The Fix:
Create a new repo and pull in just the drud dev related functionality
The Test:
run the cli tests and see what happens, run commands that don't have tests and see what happens there
Related Issue Link(s):
drud/general#32