pin jsmin to PR #34 - Fix readthedocs python2/3 compatibility, jsmin#3235
Merged
rfay merged 1 commit intoddev:masterfrom Sep 9, 2021
mootari:patch-4
Merged
pin jsmin to PR #34 - Fix readthedocs python2/3 compatibility, jsmin#3235rfay merged 1 commit intoddev:masterfrom mootari:patch-4
rfay merged 1 commit intoddev:masterfrom
mootari:patch-4
Conversation
Fixes breaking readthedocs builds due to removal of Python 2 support in setuptools 58. PR: tikitu/jsmin#34
Contributor
Author
Member
|
You're awesome. Will there be a python3 path forward on this? |
Contributor
Author
|
Afaik everything is already using Python 3. Time will tell if jsmin (which is unmaintained) has any problems running on 3 without using 2to3. More details in tikitu/jsmin#33 (comment) (Please note that I'm completely unfamiliar with the Python ecosystem.) |
Member
|
If you're "unfamiliar with python ecosystem" what am I? You seem like you know everything! |
Member
|
Interesting, I didn't run across tikitu/jsmin#33 (comment) when searching. You're awesome. |
Member
|
Thanks so much @mootari -
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3232
Fixes breaking readthedocs builds due to removal of Python 2 support in setuptools 58.
PR: tikitu/jsmin#34