Implement rotate left and right#61
Conversation
3851890 to
7adb89b
Compare
|
Thanks! One thing I am concerned about is that it might be more efficient to operate on the underlying low and high bits directly and return a new long from the computed bits just once, instead of relying on the high level wrappers that potentially allocate intermediate instances multiple times. Wdyt? |
|
It's a fair point. I'll take a look at it. |
|
Perhaps something more along these lines? |
696a678 to
5ef80d5
Compare
…ore rotate test conditions.
|
@dcodeIO When you get a moment, I think I'm ready for more input. Thanks. |
|
Thanks, looks good! Merging, and if there are still issues we can continue from here. |
|
Hi @dcodeIO, are you going to publish a new version containing this commit? |
Just a simple implementation of rotate operations using what appears to be the most recommended method these days. It should hopefully satisfy the request in #45.