Merged
Conversation
44fad52 to
bec0ae7
Compare
Closed
convex-copybara bot
referenced
this pull request
in get-convex/convex-backend
May 14, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [async-recursion](https://togithub.com/dcchut/async-recursion) | workspace.dependencies | minor | `1.0.5` -> `1.1.1` | --- ### Release Notes <details> <summary>dcchut/async-recursion (async-recursion)</summary> ### [`v1.1.1`](https://togithub.com/dcchut/async-recursion/releases/tag/v1.1.1) [Compare Source](https://togithub.com/dcchut/async-recursion/compare/v1.1.0...v1.1.1) #### What's Changed - Fix incorrect syn features by [@​dcchut](https://togithub.com/dcchut) in [https://github.com/dcchut/async-recursion/pull/44](https://togithub.com/dcchut/async-recursion/pull/44) **Full Changelog**: dcchut/async-recursion@v1.1.0...v1.1.1 ### [`v1.1.0`](https://togithub.com/dcchut/async-recursion/releases/tag/v1.1.0) [Compare Source](https://togithub.com/dcchut/async-recursion/compare/v1.0.5...v1.1.0) #### What's Changed - fix(docs): Add missing word in comment (follow-up to [#​30](https://togithub.com/dcchut/async-recursion/issues/30)) by [@​LeoniePhiline](https://togithub.com/LeoniePhiline) in [https://github.com/dcchut/async-recursion/pull/31](https://togithub.com/dcchut/async-recursion/pull/31) - Added lifetime bounds to nested references (fixes [#​34](https://togithub.com/dcchut/async-recursion/issues/34), [#​37](https://togithub.com/dcchut/async-recursion/issues/37)) in [https://github.com/dcchut/async-recursion/pull/38](https://togithub.com/dcchut/async-recursion/pull/38) - Added support for `Sync` argument (thanks [@​planetoryd](https://togithub.com/planetoryd)) in [https://github.com/dcchut/async-recursion/pull/40](https://togithub.com/dcchut/async-recursion/pull/40) #### New Contributors - [@​LeoniePhiline](https://togithub.com/LeoniePhiline) made their first contribution in [https://github.com/dcchut/async-recursion/pull/31](https://togithub.com/dcchut/async-recursion/pull/31) **Full Changelog**: dcchut/async-recursion@v1.0.5...v1.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekday after 5pm and before 8pm" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/get-convex/convex). GitOrigin-RevId: 4f5260c40f9e44a3710159f667c2f4d002bddbf6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows a
Syncbound to be included on the future returned by the modified function:As mentioned in this comment, a
Syncbound on aFutureis useless, since you can't do anything with a&Future. That being said, you may still want to store the resulting future in a struct, and you might want that struct to beSync, so there are use-cases here.Given that this is something that most people shouldn't need (nor use!), a
Syncbound is not included by default.