Fixes #669 -- Load favorites queries from and save to --myclirc#697
Merged
Fixes #669 -- Load favorites queries from and save to --myclirc#697
Conversation
f7d7978 to
be7d1f5
Compare
Codecov Report
@@ Coverage Diff @@
## master #697 +/- ##
==========================================
- Coverage 77.96% 77.96% -0.01%
==========================================
Files 25 25
Lines 2383 2387 +4
==========================================
+ Hits 1858 1861 +3
- Misses 525 526 +1
Continue to review full report at Codecov.
|
amjith
reviewed
Dec 12, 2018
mycli/sqlcompleter.py
Outdated
| fuzzy=False) | ||
| completions.extend(special) | ||
| elif suggestion['type'] == 'favoritequery': | ||
| from .packages.special.iocommands import favoritequeries |
Member
There was a problem hiding this comment.
Can you help me understand why this import statement is inside this elif clause instead of at the top of the file?
Contributor
Author
There was a problem hiding this comment.
@amjith Leftovers of testing/debugging. I've moved it back to the top of the file where it belongs. Good catch! 🙂
Member
|
Works great! Nice work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Favorite queries were being loaded from and save to the default configuration file (
~/.myclirc) only. This PR fixes that issue by making sure thatFavoriteQueriesinstance is created with the config loaded from--myclircargument.Fixes #669.
Checklist
changelog.md.AUTHORSfile (or it's already there).