Skip to content

🐛 Fix memory leak in recursivePostRetry #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dawsbot merged 2 commits into from
Apr 6, 2023
Merged

🐛 Fix memory leak in recursivePostRetry #207

dawsbot merged 2 commits into from
Apr 6, 2023

Conversation

@dawsbot
Copy link
Owner

@dawsbot dawsbot commented Apr 6, 2023

Closes #204

@dawsbot dawsbot changed the title Fix memory leak in recursivePostRetry 🐛 Fix memory leak in recursivePostRetry Apr 6, 2023
@github-actions
Copy link

github-actions bot commented Apr 6, 2023 •
edited
Loading

size-limit report 📦

Path Size
etherToWei 3.49 KB (0%)
JsonRpcProvider 19.84 KB (0%)
Contract 15.02 KB (0%)

@dawsbot dawsbot force-pushed the bugfix-memory-leak branch from a56785c to 0d751b7 Compare April 6, 2023 19:44
@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

Patch coverage: 95.31% and project coverage change: -0.38 ⚠️

Comparison is base (b2c0811) 91.03% compared to head (0d751b7) 90.65%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   91.03%   90.65%   -0.38%     
==========================================
  Files          39       39              
  Lines         970     1017      +47     
  Branches      282      289       +7     
==========================================
+ Hits          883      922      +39     
- Misses         77       85       +8     
  Partials       10       10
Impacted Files Coverage Δ
src/classes/utils/fetchers.ts 93.33% <ø> (ø)
src/providers/utils/chains-info.ts 100.00% <ø> (ø)
src/providers/FallthroughProvider.ts 89.47% <90.90%> (-0.53%) ⬇️
src/classes/utils/encode-decode-transaction.ts 91.42% <92.59%> (-2.33%) ⬇️
src/classes/Contract.ts 100.00% <100.00%> (ø)
src/classes/utils/clean-block.ts 90.00% <100.00%> (-10.00%) ⬇️
src/classes/utils/clean-transaction-receipt.ts 86.66% <100.00%> (+0.45%) ⬆️
src/classes/utils/clean-transaction.ts 100.00% <100.00%> (ø)
src/logger/package-version.ts 100.00% <100.00%> (ø)
src/providers/BaseProvider.ts 98.97% <100.00%> (+0.11%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dawsbot dawsbot merged commit 0f4df8e into master Apr 6, 2023
@dawsbot dawsbot deleted the bugfix-memory-leak branch April 6, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Memory leak in contract.claimableTokens?

3 participants

@dawsbot @codecov-commenter