Conversation
and start on docs
and a lot of typos
|
Thanks! I'll take a look as soon as I can carve out time. Appreciate the effort! |
| <script type="text/javascript"> | ||
| $(document).ready(function() { | ||
| $('#example-includeSelectAllOption-disbled').multiselect({ | ||
| $('#example-includeSelectAllOption-disabled').multiselect({ |
There was a problem hiding this comment.
Can you fix the type in the select id at line 2549? Going through tests and documentation, I just noticed that the typo prevents the example from working.
|
Looks great. Tests and all examples in the docs look good. Left a minor comment of a typo in the docs. @tiesont if you get the chance to have a look, please do. If you are happy, I can merge the PR. |
I don't see anything in the change log that looks like it would be a problem. Haven't had a chance to pull down the PR and verify it locally, but don't let that be a hold-up, if you think it's good. |
This is a breaking change, so I set the version to 2.0.0, but if you have a release process to handle that, I can undo that.
All the tests pass (I had to update one when I updated jquery), and all the examples in the docs page work.