fix: stats use .get() instead of [] indexing to avoid panics
#3306
+50
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing keys when using old stats cache file Co-Authored-By: Claude <81847+claude@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a panic issue in the stats command that occurred when reading old cache files missing newer fields (e.g., flag_weight). The fix refactors the JSON deserialization code to use safe .get() method calls instead of direct [] indexing.
Changes:
- Added import for
ValueObjectAccesstrait to enable.get()method onOwnedValue - Introduced helper closures for safe field access with appropriate defaults
- Refactored all field assignments in
from_owned_valueto use safe accessors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on missing keys when using old stats cache file