feat: MCP - add expert guidance, common patterns, MCP optimized descriptions & usage hints #3303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also remove apply_dp support as its not needed Co-Authored-By: Claude <81847+claude@users.noreply.github.com>
…iptions Co-Authored-By: Claude <81847+claude@users.noreply.github.com>
Co-Authored-By: Claude <81847+claude@users.noreply.github.com>
Co-Authored-By: Claude <81847+claude@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the MCP (Model Context Protocol) integration for qsv by adding expert guidance, common patterns, and optimized descriptions to help AI assistants make better decisions when working with CSV data.
Changes:
- Adds comprehensive usage guidance (WHEN_TO_USE, COMMON_PATTERNS, ERROR_PREVENTION_HINTS) to TypeScript MCP tools
- Implements README.md hint extraction in Rust to automatically populate behavioral hints from emoji markers
- Updates behavioral hints (streamable, indexed, memory) across 25+ JSON skill files for accuracy
- Removes applydp command from MCP skills (DataPusher+ specific variant)
- Enhances tool and parameter descriptions with contextual examples and performance warnings
Reviewed changes
Copilot reviewed 37 out of 37 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/mcp_skills_gen.rs | Adds README.md parsing to extract behavioral hints from emoji markers; removes applydp from commands list |
| .claude/skills/src/mcp-tools.ts | Adds expert guidance dictionaries (WHEN_TO_USE_GUIDANCE, COMMON_PATTERNS, ERROR_PREVENTION_HINTS) and description enhancement functions |
| .claude/skills/src/mcp-server.ts | Enhances filesystem tool descriptions with detailed usage guidance and workflows |
| .claude/skills/src/mcp-pipeline.ts | Expands pipeline tool description with benefits, limitations, common workflows, and concrete examples |
| .claude/skills/qsv/*.json (25 files) | Updates behavioral hints to accurately reflect memory characteristics and index support |
| .claude/skills/qsv/qsv-applydp.json | Removes file (DataPusher+ specific command) |
Co-Authored-By: Claude <81847+claude@users.noreply.github.com>
Co-Authored-By: Claude <81847+claude@users.noreply.github.com>
harmless, but circular hint - chicken-egg Co-Authored-By: Claude <81847+claude@users.noreply.github.com>
Co-Authored-By: Claude <81847+claude@users.noreply.github.com>
Co-Authored-By: Claude <81847+claude@users.noreply.github.com>
Co-Authored-By: Claude <81847+claude@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.