refactor: MCP #3291
Merged
refactor: MCP #3291
+577
−2,549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jqnatividad
commented
Jan 7, 2026
- removed examples parsing for skills JSON until we can make it bullet-proof
- handle both prod and test builds
- add more logging
- add more robust error handling
- smartly use --output option for temp files and stdout based on command class
…d stdout intelligently
…nerating skills JSON file
- for small output less than 1mb (Claude Desktop limit), return output to stdout - for large output, auto use --output option and return metadata to user of the output file auto-created in the working dir
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the MCP (Model Context Protocol) infrastructure to improve robustness and handle both production and test builds properly. The key changes include:
- Removed examples parsing from skills JSON generation until it can be made bullet-proof
- Added smart handling of build paths for both production (
dist/) and test (dist/src/) builds - Implemented intelligent temp file management based on command classification
- Enhanced error handling and logging throughout the MCP server
- Updated all skill definitions from version 12.0.0 to 13.0.0
Reviewed changes
Copilot reviewed 81 out of 101 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/bin/qsv-skill-gen.rs | Removed examples parsing, added argument ordering preservation, improved robust argument extraction |
| .claude/skills/src/version.ts | Added production vs test build path detection for package.json |
| .claude/skills/src/loader.ts | Added production vs test build path detection for qsv directory |
| .claude/skills/src/mcp-tools.ts | Added smart temp file handling based on command class, MCP response size limits, and detailed logging |
| .claude/skills/src/mcp-server.ts | Added comprehensive logging for tool handler registration |
| .claude/skills/src/mcp-filesystem.ts | Updated comments from "CSV" to "tabular data" |
| .claude/skills/qsv/*.json | Removed examples/examples_ref fields, updated version to 13.0.0, preserved argument order |
| .claude/skills/tests/*.{js,d.ts,map} | Removed compiled test files (now in dist/ only) |
| .claude/skills/package.json | Added separate build:test script, updated version |
| .claude/skills/.gitignore | Added patterns to ignore compiled test files outside dist/ |
| .claude/skills/README.md | Updated documentation links to new paths |
Files not reviewed (1)
- .claude/skills/package-lock.json: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.