deps: polars bump to rev c241260 #3276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Polars dependency from revision 5deaf7e to c241260 (still at version 0.52.0, tag py-1.36.1). The update includes necessary API adaptations to maintain compatibility with Polars' CsvWriter interface changes that now require type conversions for format strings and null values.
- Updated Polars git revision in Cargo.toml and Cargo.lock
- Adapted CsvWriter API calls to use explicit type conversions (.into() or .map(Into::into)) for date/time format parameters and null values
- Updated test expectation to reflect improved row estimation from Polars optimizer
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Updated polars dependency git revision from 5deaf7e to c241260 with corresponding comment update |
| Cargo.lock | Updated source URLs for all polars-* packages to reference the new revision hash |
| README.md | Updated badge to reflect the new polars revision c241260 |
| src/cmd/sqlp.rs | Adapted CsvWriter format methods to use explicit .into() conversions for datetime/date/time formats and null value |
| src/cmd/joinp.rs | Applied same CsvWriter API changes as sqlp.rs for consistency |
| src/cmd/pivotp.rs | Introduced PlSmallStr variable for datetime format to accommodate CsvWriter API change |
| tests/test_sqlp.rs | Updated expected row estimation from 100 to 181, reflecting improved optimizer in new Polars revision |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.