refactor: mcp server improvements #3274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set QSV_WORKING_DIR and QSV_ALLOWED_DIRS during install with sensible defaults
…ed in the wrong order also more log message to help with debugging
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the MCP server to improve debugging capabilities, user experience during installation, and robustness of file path handling.
- Enhanced debug logging throughout the execution pipeline for better troubleshooting
- Improved installer UX with interactive prompts for environment configuration
- Fixed input parameter handling to prevent duplicate arguments when both
input_fileandinputare provided
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.claude/skills/src/mcp-tools.ts |
Added comprehensive debug logging for file path resolution and skill execution; fixed logic to prevent duplicate input arguments when both input_file and input parameters are provided |
.claude/skills/src/mcp-server.ts |
Updated SkillExecutor initialization to accept QSV_BIN_PATH environment variable for fully qualified binary path |
.claude/skills/src/executor.ts |
Enhanced error logging with detailed command execution information including full command, binary path, arguments, exit codes, and stderr/stdout lengths |
.claude/skills/scripts/install-mcp.js |
Significantly improved installation UX with interactive prompts for QSV_WORKING_DIR and QSV_ALLOWED_DIRS, platform-specific defaults, better verification steps, and enhanced configuration summary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inputandinput_fileare processed properly