refactor: qsv Skills Agent #3267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mples based on CI tests
There was a problem hiding this comment.
devskim found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the qsv Skills Agent to improve robustness and maintainability. The key changes include adopting qsv-docopt for more robust command usage text parsing and implementing a new "load-as-needed" examples system via a new CLI (qsv-test-examples-gen) that leverages CI tests, while maintaining lightweight examples parsed from Usage text.
Reviewed changes
Copilot reviewed 32 out of 129 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
.claude/skills/examples/qsv-pivotp-examples.json |
Added new example file with duplicate "main" entries for pivotp command |
.claude/skills/examples/qsv-partition-examples.json |
Added comprehensive partition command examples covering various scenarios |
.claude/skills/examples/qsv-moarstats-examples.json |
Added extensive moarstats examples including statistical operations and edge cases |
.claude/skills/examples/qsv-luau-examples.json |
Added comprehensive Luau scripting examples for map/filter operations |
.claude/skills/examples/qsv-joinp-examples.json |
Added detailed joinp examples including multiple duplicate "headers" entries |
.claude/skills/examples/qsv-join-examples.json |
Added join command examples with multiple duplicate "headers" entries |
.claude/skills/examples/qsv-input-examples.json |
Added input command examples covering various input handling scenarios |
.claude/skills/examples/qsv-index-examples.json |
Added index command examples for index operations |
.claude/skills/examples/qsv-headers-examples.json |
Added headers command examples for header manipulation |
.claude/skills/examples/qsv-geoconvert-examples.json |
Added geoconvert examples for geographic format conversion |
.claude/skills/examples/qsv-geocode-examples.json |
Added geocode examples for geocoding operations |
.claude/skills/examples/qsv-frequency-examples.json |
Added comprehensive frequency analysis examples |
.claude/skills/examples/qsv-foreach-examples.json |
Added foreach command examples for iteration operations |
.claude/skills/examples/qsv-fixlengths-examples.json |
Added fixlengths examples for length normalization |
.claude/skills/examples/qsv-fill-examples.json |
Added fill command examples for data filling operations |
.claude/skills/examples/qsv-fetch-examples.json |
Added fetch examples for HTTP operations |
.claude/skills/examples/qsv-extsort-examples.json |
Added external sort examples |
.claude/skills/examples/qsv-extdedup-examples.json |
Added external deduplication examples |
.claude/skills/examples/qsv-explode-examples.json |
Added explode command examples for delimiter splitting |
.claude/skills/examples/qsv-exclude-examples.json |
Added exclude command examples |
.claude/skills/examples/qsv-describegpt-examples.json |
Added describegpt examples for GPT-based descriptions |
… formatted correctly
also make clippy happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qsv-test-examples-gen)