feat: qsv Agent Skills 🤖 #3264
Merged
feat: qsv Agent Skills 🤖 #3264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
devskim found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a comprehensive Agent Skills system for qsv that auto-generates skill definitions from command USAGE text for integration with the Claude Agent SDK. The implementation includes a Rust-based skill generator, TypeScript execution framework, and extensive documentation.
Key Changes:
- New
qsv-skill-genbinary that parses USAGE text from all qsv commands and generates JSON skill definitions - TypeScript executor wrapper with type-safe skill loading and execution
- Fluent pipeline composition API for chaining qsv operations
- Complete documentation covering design, integration patterns, and implementation summary
Reviewed changes
Copilot reviewed 82 out of 85 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/bin/qsv-skill-gen.rs |
Skill generator binary (498 lines) - parses USAGE text and generates JSON skills |
Cargo.toml |
Added new binary entry for qsv-skill-gen |
.gitignore |
Updated to allow skill JSON files while ignoring other JSON |
.claude/skills/src/types.ts |
TypeScript type definitions for skills and execution |
.claude/skills/src/loader.ts |
Skill loading and discovery functionality |
.claude/skills/src/executor.ts |
Skill execution engine with parameter validation |
.claude/skills/src/pipeline.ts |
Fluent API for composing skill pipelines |
.claude/skills/src/index.ts |
Public API exports |
.claude/skills/qsv/*.json |
Generated skill definitions for qsv commands (66 files) |
docs/AGENT_SKILLS_*.md |
Comprehensive documentation (design, integration, summaries) |
Files not reviewed (1)
- .claude/skills/package-lock.json: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used Claude Code to create a complete Agent Skills implementation!