fix: refresh_cpu_all() -> refresh_cpu_list(sysinfo::CpuRefreshKind::n… #3261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…othing()) we only need the make/model of the CPU for version, we don't need any more metadata for CPUs. Apparently, for systems with a lot of CPUs, this fetches so much metadata that it vastly increases startup time when --version is used. resolves #3260
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the performance of the --version command by reducing CPU metadata fetching. On systems with many CPUs, the previous refresh_cpu_all() call would fetch extensive CPU metadata (frequency, usage, etc.), significantly increasing startup time when --version is used.
Key Changes
- Replaced
refresh_cpu_all()withrefresh_cpu_list(CpuRefreshKind::nothing())to fetch only the CPU brand information - Added a clarifying comment explaining the optimization
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…othing())
we only need the make/model of the CPU for version, we don't need any more metadata for CPUs. Apparently, for systems with a lot of CPUs, this fetches so much metadata that it vastly increases startup time when --version is used.
resolves #3260