feat: moarstats add --force and --jobs options
#3253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also wordsmith usage text regarding bivariate stats file
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the moarstats command by adding two new command-line options: --force to force recomputation of stats even when a cached version exists, and --jobs to allow users to specify the number of parallel jobs for processing. The PR also improves documentation clarity regarding the handling of temporary files when joining datasets for bivariate statistics computation.
Key Changes
- Added
--forceflag to bypass stats cache and force recomputation - Added
--jobsoption to control parallel processing job count - Improved usage text to clarify that joined dataset temporary files are automatically deleted
- Refactored function names for better clarity (
compute_all_bivariatestats_from_reader→compute_all_bivariatestats_sequential)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also wordsmith usage text regarding bivariate stats file